广告管理单元测试完善:position魔值用枚举替换

This commit is contained in:
gaoqr
2025-10-28 17:11:16 +08:00
parent 3d05c39f22
commit 1f4ec69d70
2 changed files with 18 additions and 10 deletions
@@ -5,6 +5,7 @@ import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.Adverti
import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementRePublishReqVO; import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementRePublishReqVO;
import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementRespVO; import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementRespVO;
import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementSaveReqVO; import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementSaveReqVO;
import com.cf.imes.module.system.enums.advertisement.AdvertisementPositionEnum;
import com.cf.imes.module.system.service.funds.advertisement.AdvertisementService; import com.cf.imes.module.system.service.funds.advertisement.AdvertisementService;
import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -52,7 +53,7 @@ public class AdvertisementControllerTest {
void testCreateAdvertisement() throws Exception { void testCreateAdvertisement() throws Exception {
AdvertisementSaveReqVO reqVO = new AdvertisementSaveReqVO(); AdvertisementSaveReqVO reqVO = new AdvertisementSaveReqVO();
reqVO.setAdName("测试广告"); reqVO.setAdName("测试广告");
reqVO.setAdPosition(List.of(1)); reqVO.setAdPosition(List.of(AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus()));
reqVO.setAdImagePath("test.jpg"); reqVO.setAdImagePath("test.jpg");
LocalDate now = LocalDate.now(); LocalDate now = LocalDate.now();
reqVO.setStartTime(now); reqVO.setStartTime(now);
@@ -74,7 +75,7 @@ public class AdvertisementControllerTest {
AdvertisementSaveReqVO reqVO = new AdvertisementSaveReqVO(); AdvertisementSaveReqVO reqVO = new AdvertisementSaveReqVO();
reqVO.setId(1L); reqVO.setId(1L);
reqVO.setAdName("测试更新广告"); reqVO.setAdName("测试更新广告");
reqVO.setAdPosition(List.of(1)); reqVO.setAdPosition(List.of(AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus()));
reqVO.setAdImagePath("test.jpg"); reqVO.setAdImagePath("test.jpg");
LocalDate now = LocalDate.now(); LocalDate now = LocalDate.now();
reqVO.setStartTime(now); reqVO.setStartTime(now);
@@ -9,6 +9,7 @@ import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.Adverti
import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementSaveReqVO; import com.cf.imes.module.system.controller.admin.funds.advertisement.vo.AdvertisementSaveReqVO;
import com.cf.imes.module.system.dal.dataobject.funds.advertisement.AdvertisementDO; import com.cf.imes.module.system.dal.dataobject.funds.advertisement.AdvertisementDO;
import com.cf.imes.module.system.dal.mysql.funds.advertisement.AdvertisementMapper; import com.cf.imes.module.system.dal.mysql.funds.advertisement.AdvertisementMapper;
import com.cf.imes.module.system.enums.advertisement.AdvertisementPositionEnum;
import com.cf.imes.module.system.enums.advertisement.AdvertisementStatusEnum; import com.cf.imes.module.system.enums.advertisement.AdvertisementStatusEnum;
import jakarta.annotation.Resource; import jakarta.annotation.Resource;
import org.junit.jupiter.api.MethodOrderer; import org.junit.jupiter.api.MethodOrderer;
@@ -95,7 +96,9 @@ public class AdvertisementServiceImplTest extends BaseDbAndRedisUnitTest {
reqVO.setStartTime(LocalDate.now()); reqVO.setStartTime(LocalDate.now());
reqVO.setEndTime(LocalDate.now().plusDays(1)); reqVO.setEndTime(LocalDate.now().plusDays(1));
reqVO.setAdName("Ad-CREATE-1"); reqVO.setAdName("Ad-CREATE-1");
reqVO.setAdPosition(List.of(3, 1, 3)); reqVO.setAdPosition(List.of(AdvertisementPositionEnum.BASECONFIG_FUNDSQUERY_CAROUSEL.getStatus()
, AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus()
, AdvertisementPositionEnum.BASECONFIG_FUNDSQUERY_CAROUSEL.getStatus()));
reqVO.setAdImagePath("https://example.com/image.png"); reqVO.setAdImagePath("https://example.com/image.png");
Long id = advertisementService.create(reqVO); Long id = advertisementService.create(reqVO);
@@ -105,7 +108,7 @@ public class AdvertisementServiceImplTest extends BaseDbAndRedisUnitTest {
// 验证id // 验证id
assertEquals(insertedOne.getId(), id); assertEquals(insertedOne.getId(), id);
// 验证 adPosition 去重排序 // 验证 adPosition 去重排序
assertEquals(List.of(1, 3), insertedOne.getAdPosition()); assertEquals(List.of(AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus(), AdvertisementPositionEnum.BASECONFIG_FUNDSQUERY_CAROUSEL.getStatus()), insertedOne.getAdPosition());
// 验证状态 // 验证状态
assertEquals(AdvertisementStatusEnum.UNPUBLISHED.getStatus(), insertedOne.getStatus()); assertEquals(AdvertisementStatusEnum.UNPUBLISHED.getStatus(), insertedOne.getStatus());
// 验证名称 // 验证名称
@@ -139,7 +142,9 @@ public class AdvertisementServiceImplTest extends BaseDbAndRedisUnitTest {
reqVO.setStartTime(LocalDate.now()); reqVO.setStartTime(LocalDate.now());
reqVO.setEndTime(LocalDate.now().plusDays(1)); reqVO.setEndTime(LocalDate.now().plusDays(1));
reqVO.setAdName("Ad-CREATE-2"); reqVO.setAdName("Ad-CREATE-2");
reqVO.setAdPosition(List.of(3, 1, 3)); reqVO.setAdPosition(List.of(AdvertisementPositionEnum.BASECONFIG_FUNDSQUERY_CAROUSEL.getStatus()
, AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus()
, AdvertisementPositionEnum.BASECONFIG_FUNDSQUERY_CAROUSEL.getStatus()));
reqVO.setAdImagePath("https://example.com/image.png"); reqVO.setAdImagePath("https://example.com/image.png");
insertTwoId = advertisementService.create(reqVO); insertTwoId = advertisementService.create(reqVO);
@@ -161,14 +166,16 @@ public class AdvertisementServiceImplTest extends BaseDbAndRedisUnitTest {
updateReqVO.setStartTime(LocalDate.now()); updateReqVO.setStartTime(LocalDate.now());
updateReqVO.setEndTime(LocalDate.now().plusDays(1)); updateReqVO.setEndTime(LocalDate.now().plusDays(1));
updateReqVO.setAdName("Ad-UPDATE-1"); updateReqVO.setAdName("Ad-UPDATE-1");
updateReqVO.setAdPosition(List.of(1,3)); updateReqVO.setAdPosition(List.of(AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus()
, AdvertisementPositionEnum.BASECONFIG_FUNDSQUERY_CAROUSEL.getStatus()));
updateReqVO.setAdImagePath("https://example.com/image.jpg"); updateReqVO.setAdImagePath("https://example.com/image.jpg");
advertisementService.update(updateReqVO); advertisementService.update(updateReqVO);
AdvertisementDO db = advertisementMapper.selectById(insertedOne.getId()); AdvertisementDO db = advertisementMapper.selectById(insertedOne.getId());
assertEquals(db.getAdName(), "Ad-UPDATE-1"); assertEquals(db.getAdName(), "Ad-UPDATE-1");
assertEquals(db.getAdPosition(), List.of(1,3)); assertEquals(db.getAdPosition(), List.of(AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus()
, AdvertisementPositionEnum.BASECONFIG_FUNDSQUERY_CAROUSEL.getStatus()));
assertEquals(db.getAdImagePath(), "https://example.com/image.jpg"); assertEquals(db.getAdImagePath(), "https://example.com/image.jpg");
} }
@@ -192,7 +199,7 @@ public class AdvertisementServiceImplTest extends BaseDbAndRedisUnitTest {
updateReqVO.setStartTime(LocalDate.now().minusDays(5)); updateReqVO.setStartTime(LocalDate.now().minusDays(5));
updateReqVO.setEndTime(LocalDate.now().minusDays(4)); updateReqVO.setEndTime(LocalDate.now().minusDays(4));
updateReqVO.setAdName("Ad-UPDATE-2"); updateReqVO.setAdName("Ad-UPDATE-2");
updateReqVO.setAdPosition(List.of(2)); updateReqVO.setAdPosition(List.of(AdvertisementPositionEnum.SYSTEMCONFIG_AMOUNTQUERY_CAROUSEL.getStatus()));
assertDoesNotThrow(() -> advertisementService.update(updateReqVO)); assertDoesNotThrow(() -> advertisementService.update(updateReqVO));
} }
@@ -250,11 +257,11 @@ public class AdvertisementServiceImplTest extends BaseDbAndRedisUnitTest {
@Test @Test
@Order(17) @Order(17)
void testGetByPosition() { void testGetByPosition() {
List<AdvertisementRespVO> advertisementRespVOS = advertisementService.getAdvertisementByPosition(1); List<AdvertisementRespVO> advertisementRespVOS = advertisementService.getAdvertisementByPosition(AdvertisementPositionEnum.WORKBENCH_CAROUSEL.getStatus());
assertEquals(1, advertisementRespVOS.size()); assertEquals(1, advertisementRespVOS.size());
advertisementRespVOS = advertisementService.getAdvertisementByPosition(2); advertisementRespVOS = advertisementService.getAdvertisementByPosition(AdvertisementPositionEnum.SYSTEMCONFIG_AMOUNTQUERY_CAROUSEL.getStatus());
assertEquals(0, advertisementRespVOS.size()); assertEquals(0, advertisementRespVOS.size());
} }