mirror of
http://192.168.1.205:9980/cf_devdept2/cf_imes_server.git
synced 2026-08-12 21:02:08 +08:00
Sonar代码问题修改
This commit is contained in:
+6
-3
@@ -54,6 +54,9 @@ public class MenuServiceImpl implements MenuService {
|
||||
@Autowired
|
||||
private RedisTemplate redisTemplate;
|
||||
|
||||
|
||||
private static final String FIELD_CHARACTER = ":*:%s";
|
||||
|
||||
@Override
|
||||
@CacheEvict(value = RedisKeyConstants.PERMISSION_MENU_ID_LIST, key = "#createReqVO.permission",
|
||||
condition = "#createReqVO.permission != null")
|
||||
@@ -137,21 +140,21 @@ public class MenuServiceImpl implements MenuService {
|
||||
CompletableFuture.runAsync(() -> {
|
||||
if (ObjectUtil.isNotNull(oldPermission)) {
|
||||
// 移除 USER_ROLE_ID_LIST:*:旧的permission
|
||||
String oldMenuPerPattern = String.format(String.valueOf(new StringBuffer(RedisKeyConstants.PERMISSION_MENU_ID_LIST).append(":*:%s")), oldPermission);
|
||||
String oldMenuPerPattern = String.format(String.valueOf(new StringBuffer(RedisKeyConstants.PERMISSION_MENU_ID_LIST).append(FIELD_CHARACTER)), oldPermission);
|
||||
Long oldBatchDelPerNum = scanAndDelKeys(oldMenuPerPattern);
|
||||
log.info("[updateMenu] 批量删除redis[{}]数量:{}", oldMenuPerPattern, oldBatchDelPerNum);
|
||||
}
|
||||
|
||||
if (ObjectUtil.isNotNull(newPermission)) {
|
||||
// 移除 USER_ROLE_ID_LIST:*:新的permission
|
||||
String newMenuPerPattern = String.format(String.valueOf(new StringBuffer(RedisKeyConstants.PERMISSION_MENU_ID_LIST).append(":*:%s")), newPermission);
|
||||
String newMenuPerPattern = String.format(String.valueOf(new StringBuffer(RedisKeyConstants.PERMISSION_MENU_ID_LIST).append(FIELD_CHARACTER)), newPermission);
|
||||
Long newBatchDelPerNum = scanAndDelKeys(newMenuPerPattern);
|
||||
log.info("[updateMenu] 批量删除redis[{}]数量:{}", newMenuPerPattern, newBatchDelPerNum);
|
||||
}
|
||||
|
||||
if (ObjectUtil.isNotNull(menuId)) {
|
||||
// 移除 MENU_ROLE_ID_LIST:*:menuId
|
||||
String menuRolePattern = String.format(String.valueOf(new StringBuffer(RedisKeyConstants.MENU_ROLE_ID_LIST).append(":*:%s")), menuId);
|
||||
String menuRolePattern = String.format(String.valueOf(new StringBuffer(RedisKeyConstants.MENU_ROLE_ID_LIST).append(FIELD_CHARACTER)), menuId);
|
||||
Long batchDelRoleNum = scanAndDelKeys(menuRolePattern);
|
||||
log.info("[deleteMenu] 批量删除redis[{}]数量:{}", menuRolePattern, batchDelRoleNum);
|
||||
}
|
||||
|
||||
+6
-3
@@ -46,6 +46,9 @@ public class SocialUserServiceImpl implements SocialUserService {
|
||||
@Resource
|
||||
private SocialClientService socialClientService;
|
||||
|
||||
|
||||
private static final String FIELD_SOCIAL = "社交用户不能为空";
|
||||
|
||||
@Override
|
||||
public List<SocialUserDO> getSocialUserList(Long userId, Integer userType) {
|
||||
// 获得绑定
|
||||
@@ -63,7 +66,7 @@ public class SocialUserServiceImpl implements SocialUserService {
|
||||
// 获得社交用户
|
||||
SocialUserDO socialUser = authSocialUser(reqDTO.getSocialType(), reqDTO.getUserType(),
|
||||
reqDTO.getCode(), reqDTO.getState());
|
||||
Assert.notNull(socialUser, "社交用户不能为空");
|
||||
Assert.notNull(socialUser, FIELD_SOCIAL);
|
||||
|
||||
// 社交用户可能之前绑定过别的用户,需要进行解绑
|
||||
socialUserBindMapper.deleteByUserTypeAndSocialUserId(reqDTO.getUserType(), socialUser.getId());
|
||||
@@ -101,7 +104,7 @@ public class SocialUserServiceImpl implements SocialUserService {
|
||||
}
|
||||
// 获得社交用户
|
||||
SocialUserDO socialUser = socialUserMapper.selectById(socialUserBind.getSocialUserId());
|
||||
Assert.notNull(socialUser, "社交用户不能为空");
|
||||
Assert.notNull(socialUser, FIELD_SOCIAL);
|
||||
return new SocialUserRespDTO(socialUser.getOpenid(), socialUser.getNickname(), socialUser.getAvatar(),
|
||||
socialUserBind.getUserId());
|
||||
}
|
||||
@@ -110,7 +113,7 @@ public class SocialUserServiceImpl implements SocialUserService {
|
||||
public SocialUserRespDTO getSocialUserByCode(Integer userType, Integer socialType, String code, String state) {
|
||||
// 获得社交用户
|
||||
SocialUserDO socialUser = authSocialUser(socialType, userType, code, state);
|
||||
Assert.notNull(socialUser, "社交用户不能为空");
|
||||
Assert.notNull(socialUser, FIELD_SOCIAL);
|
||||
|
||||
// 获得绑定用户
|
||||
SocialUserBindDO socialUserBind = socialUserBindMapper.selectByUserTypeAndSocialUserId(userType,
|
||||
|
||||
+7
-3
@@ -17,6 +17,10 @@ import java.util.*;
|
||||
*/
|
||||
public class OAuth2Utils {
|
||||
|
||||
|
||||
private static final String FIELD_STATE = "state";
|
||||
|
||||
|
||||
/**
|
||||
* 构建授权码模式下,重定向的 URI
|
||||
*
|
||||
@@ -31,7 +35,7 @@ public class OAuth2Utils {
|
||||
Map<String, String> query = new LinkedHashMap<>();
|
||||
query.put("code", authorizationCode);
|
||||
if (state != null) {
|
||||
query.put("state", state);
|
||||
query.put(FIELD_STATE, state);
|
||||
}
|
||||
return HttpUtils.append(redirectUri, query, null, false);
|
||||
}
|
||||
@@ -56,7 +60,7 @@ public class OAuth2Utils {
|
||||
vars.put("access_token", accessToken);
|
||||
vars.put("token_type", SecurityFrameworkUtils.AUTHORIZATION_BEARER.toLowerCase());
|
||||
if (state != null) {
|
||||
vars.put("state", state);
|
||||
vars.put(FIELD_STATE, state);
|
||||
}
|
||||
if (expireTime != null) {
|
||||
vars.put("expires_in", getExpiresIn(expireTime));
|
||||
@@ -83,7 +87,7 @@ public class OAuth2Utils {
|
||||
query.put("error", error);
|
||||
query.put("error_description", description);
|
||||
if (state != null) {
|
||||
query.put("state", state);
|
||||
query.put(FIELD_STATE, state);
|
||||
}
|
||||
return HttpUtils.append(redirectUri, query, null, !responseType.contains("code"));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user