actions/setup-pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/action-setup.git synced 2026-05-14 14:23:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: scope pm_on_fail override to the no-target-version branch

Browse Source 
Only export `pnpm_config_pm_on_fail=download` when the action is relying on
bootstrap pnpm's runtime switch. When the user passes an explicit `version:`
input, self-update aligns the binary and we should not silently override their
`devEngines.packageManager.onFail = "error"` policy.
This commit is contained in:
Zoltan Kochan
2026-05-10 23:41:39 +02:00
parent 052c4ffb7d
commit 07ad39cba4
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dist/index.js vendored
View File

File diff suppressed because one or more lines are too long

12
src/install-pnpm/run.ts
View File

@@ -67,11 +67,6 @@ export async function runSelfInstaller(inputs: Inputs): Promise<SelfInstallerRes
addPath(pnpmHome) addPath(pnpmHome)
addPath(path.join(pnpmHome, 'bin')) addPath(path.join(pnpmHome, 'bin'))
exportVariable('PNPM_HOME', pnpmHome) exportVariable('PNPM_HOME', pnpmHome)
// Force pnpm to honor manage-package-manager-versions even when the project
// pins `devEngines.packageManager.onFail = "error"`. Without this override
// the bootstrap pnpm errors with BAD_PM_VERSION instead of switching to the
// requested version on the user's first invocation (issue #252).
exportVariable('pnpm_config_pm_on_fail', 'download')
// Ensure pnpm bin link exists — npm ci sometimes doesn't create it // Ensure pnpm bin link exists — npm ci sometimes doesn't create it
if (process.platform !== 'win32') { if (process.platform !== 'win32') {
@@ -107,7 +102,12 @@ export async function runSelfInstaller(inputs: Inputs): Promise<SelfInstallerRes
} }
// No explicit target version: rely on the bootstrap pnpm to switch to // No explicit target version: rely on the bootstrap pnpm to switch to
// the version declared in packageManager/devEngines at runtime. // the version declared in packageManager/devEngines at runtime. Force
// `pmOnFail=download` so a project that pins
// `devEngines.packageManager.onFail = "error"` doesn't trip BAD_PM_VERSION
// before the switch can happen (issue #252). Scoped to this branch so users
// who pass an explicit `version:` input keep strict onFail behavior.
exportVariable('pnpm_config_pm_on_fail', 'download')
return { exitCode: 0, binDest: pnpmHome } return { exitCode: 0, binDest: pnpmHome }
} }